marvinlanhenke commented on code in PR #309:
URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542923641
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -683,6 +684,47 @@ impl Datum {
pub fn data_type(&self) -> &PrimitiveType {
&self.r#type
}
+
+ /// Create a new `Datum` with adjusted boundary for projection
+ pub fn boundary(&self, op: &PredicateOperator) -> Result<Option<Datum>> {
Review Comment:
yes - but still implemented on `Datum` or as a helper fn on `Transform` with
param: `&Datum` ? it feels strange to impl `Datum` across two modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
