rdblue commented on code in PR #4525:
URL: https://github.com/apache/iceberg/pull/4525#discussion_r846842293


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -492,6 +523,14 @@ public String doc() {
       return doc;
     }
 
+    public JsonNode initialDefaultValue() {

Review Comment:
   This API should not use Jackson classes. Instead, it should use the standard 
Iceberg in-memory representation:
   * boolean - Java primitive boolean
   * int - Java primitive int
   * long - Java primitive long
   * float - Java primitive float
   * double - Java primitive double
   * date - Java primitive int
   * time - Java primitive long
   * timestamp/timestamptz - Java primitive long
   * string - Java CharSequence
   * uuid - Java UUID
   * binary - Java ByteBuffer
   * fixed(L) - Java ByteBuffer
   * decimal(P, S) - Java BigDecimal
   * list - Java Collection
   * struct - StructLike
   * map - Java Map



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to