rdblue commented on code in PR #4525:
URL: https://github.com/apache/iceberg/pull/4525#discussion_r846842357
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -524,6 +563,91 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(NestedField.class, id, isOptional, name, type);
}
+
+ private static JsonNode validateDefault(String name, Type type, JsonNode
defaultValue) {
Review Comment:
I think this logic should be moved to a `ValueParser` with `toJson` and
`fromJson` methods, like the others. We don't want to leak any Jackson classes
in the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
