rzhang10 commented on code in PR #4525:
URL: https://github.com/apache/iceberg/pull/4525#discussion_r847769422
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -492,6 +523,14 @@ public String doc() {
return doc;
}
+ public JsonNode initialDefaultValue() {
Review Comment:
> * list - Java Collection
I think using Java `List` is more correct, as List cares about the order.
> * struct - StructLike
I see this comment:
```
/**
* Interface for accessing data by position in a schema.
* <p>
* This interface supports accessing data in top-level fields, not in nested
fields.
*/
```
in that interface, also I see the API exposes is getting fields by position,
which doesn't suit our casing of accessing fields by field id.
I think using a native Java map would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
