jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1139251647
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -248,6 +250,23 @@ public class AwsProperties implements Serializable {
*/
public static final String S3FILEIO_SESSION_TOKEN = "s3.session-token";
+ /**
+ * Configure the AWS credentials provider used to access S3FileIO. A fully
qualified concrete
+ * class with package that implements the {@link AwsCredentialsProvider}
interface is required.
+ * Class provided must be a valid implementation of the {@link
AwsCredentialsProvider} interface
+ * and that it is accessible from project's classpath.
+ *
+ * <p>Additionally, the implementation class must also have a create()
method implemented, which
+ * returns an instance of the class that provides aws credentials provider.
+ *
+ * <p>Example:
+ *
client.credentials-provider=software.amazon.awssdk.auth.credentials.SystemPropertyCredentialsProvider
+ *
+ * <p>When set, the default client factory will use this provider to get AWS
credentials provided
+ * instead of reading the default credential chain to get S3 access
credentials.
+ */
+ public static final String S3FILEIO_CREDENTIALS_PROVIDER =
"client.credentials-provider";
Review Comment:
can we do it for all clients, instead of just S3FileIO? so variable below
should also be `clientCredentialsProvider` instead of `s3CredentialsProvider`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
