bruno-roustant commented on a change in pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r520040508
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##########
@@ -51,7 +51,7 @@
// to essentially queue them up to be handled via pendingCoreOps.
private static final List<SolrCore> pendingCloses = new ArrayList<>();
- private TransientSolrCoreCacheFactory transientSolrCoreCacheFactory;
+ private TransientSolrCoreCacheFactory transientSolrCoreCacheFactory =
TransientSolrCoreCacheFactory.NO_OP;
Review comment:
If a SolrCores method accessing getTransientCacheHandler() is called
before calling load().
For example an asynchronous periodic thread that would be started with
CoreContainer and that would call getLoadedCoreNames(). This worked before even
if SolrCores.load() was called after. (first calls would return without
counting transient cores, and subsequent calls after load() would count
transient cores)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
