[ 
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376392#comment-17376392
 ] 

Dawid Weiss commented on LUCENE-10003:
--------------------------------------

Eh. I'm sorry, David, but I still see very little gain in doing all this extra 
work... I don't think I've ever had a bug resulting from an array declaration 
in either style. I like the consistency (yay) but the overhead of enforcing 
this automatically (with regexps) seems like too much wasted cpu cycles to me.

> Disallow C-style array declarations
> -----------------------------------
>
>                 Key: LUCENE-10003
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10003
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Google Java Format, that which we adhere to, disallows c-style array 
> declarations: https://google.github.io/styleguide/javaguide.html#s4.8.3-arrays
> It's also known to "Error Prone":
> https://errorprone.info/bugpattern/MixedArrayDimensions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to