[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376554#comment-17376554
]
David Smiley commented on LUCENE-10003:
---------------------------------------
This isn't about bugs; it's about style.
As long as the overhead is only executed on modified files, then surely it's
negligible? Or only do in GitHub PR, even more neglible :-)
Spotless is cool but adding a new custom formatter step is much more work than
what I did above. A spotless formatter step has to actually do the repair,
whereas the regexp detector above doesn't. The Spotless people shared docs
with me on how to write a formatter step:
https://github.com/diffplug/spotless/blob/main/CONTRIBUTING.md#how-to-add-a-new-formatterstep
> Disallow C-style array declarations
> -----------------------------------
>
> Key: LUCENE-10003
> URL: https://issues.apache.org/jira/browse/LUCENE-10003
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Google Java Format, that which we adhere to, disallows c-style array
> declarations: https://google.github.io/styleguide/javaguide.html#s4.8.3-arrays
> It's also known to "Error Prone":
> https://errorprone.info/bugpattern/MixedArrayDimensions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
