[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376753#comment-17376753
]
Uwe Schindler commented on LUCENE-10003:
----------------------------------------
I agree with Robert and Dawid. Why the hell add an extra Gradle task for
reformatting code! Please don't do this. Don't fail build!
There are no bugs caused by the style. I also prefer the type style over the
array but I see no reason to forbid one or the other.
So -1 for regex magic and -1E43 for failing builds with crazy regexes and
lookaheads.
If I were you: look into spotless API and check how to handle this in their
AST. Don't parse code multiple times with tons of different tools. Use
Spotless. Make a pull request on their repo.
Error prone is disabled by default as it breaks with newer java and is slow
like hell.
> Disallow C-style array declarations
> -----------------------------------
>
> Key: LUCENE-10003
> URL: https://issues.apache.org/jira/browse/LUCENE-10003
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Google Java Format, that which we adhere to, disallows c-style array
> declarations: https://google.github.io/styleguide/javaguide.html#s4.8.3-arrays
> It's also known to "Error Prone":
> https://errorprone.info/bugpattern/MixedArrayDimensions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
