[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424104#comment-17424104
]
Robert Muir commented on LUCENE-10143:
--------------------------------------
I didn't mean it that way, I mean look at the PR. there are like 33 subclasses
impacted, only 1 of them is a delegator, that's all.
I just mean it is a more complex general issue here than incomplete delegator:
One issue: Lots of DataInput/Output subclasses, why so many? In some cases it
seems like bad design. We are asking for poor performance by having so much
custom/duplicate code.
For example: Why does MultiLevelSkipListReader buffer its top skiplevels with a
custom DataInput subclass, instead of something like a byte[] and just reuse
ByteArrayDataInput?
Another example: Why does FST BytesStore have its own Reversed and Forward
BytesReader classes inside, but then also have separate
o.a.l.util.ForwardBytesReader and ReversedBytesReader?
Another example: Why do we have at least 3 classes reading indexinput from a
ByteBuffer?
I honestly just don't see so many delegators here. If i did, i'd suggest a
FilteredIndexInput or whatever to make them easy to fix. Instead I see a more
complicated mess.
> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
> Key: LUCENE-10143
> URL: https://issues.apache.org/jira/browse/LUCENE-10143
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: screenshot-1.png
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
