[ 
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424334#comment-17424334
 ] 

Uwe Schindler commented on LUCENE-10143:
----------------------------------------

I think we were all a bit overreacting with "let's do something now". So let's 
go iterative steps to refactor IndexOutput vs. DataOutput and the subclass / 
code duplication hell. Maybe we should check some options, my favourite would 
be to make DataOutput and DataInput an interface with some default methods, as 
well as those like FSTBytesReader (and others).

If nobody complains I would merge the PR tomorrow.

> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
>                 Key: LUCENE-10143
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10143
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: screenshot-1.png
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to