[ 
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424121#comment-17424121
 ] 

Robert Muir commented on LUCENE-10143:
--------------------------------------

I also think the DataInput vs IndexInput causes more trouble than its worth 
with this duplication. It definitely makes it more difficult to consolidate and 
reuse some of this stuff.

In theory a IndexInput is just a DataInput but just adds getFilePointer() and 
seek(). But in practice, the problem is you really need the same "get and set 
position", so DataInput got a skipBytes() (seek() with a different name). Some 
may also have a setPosition() doing the same thing. And most implementations 
have something like a getPosition() which is just a different name for 
getFilePointer().

> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
>                 Key: LUCENE-10143
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10143
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: screenshot-1.png
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to