rmuir commented on code in PR #16371:
URL: https://github.com/apache/lucene/pull/16371#discussion_r3667685275
##########
lucene/analysis/icu/build.gradle:
##########
@@ -284,7 +284,7 @@ configure(project(":lucene:analysis:common")) {
configure(project(":lucene:core")) {
setupIcuDependencies(project)
- tasks.register("generateUnicodeProps", {
+ tasks.register("generateCaseFolding", {
Review Comment:
another idea on the names, one of these is doing expansion and the other is
doing compression/folding.
we might want to eventually fix the java file in o.a.l.u.automaton to make
this clear too. Its named `CaseFolding.java` but it isn't doing any folding, it
is doing expansion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
