uschindler commented on code in PR #16371:
URL: https://github.com/apache/lucene/pull/16371#discussion_r3672160895
##########
lucene/analysis/icu/build.gradle:
##########
@@ -284,7 +284,7 @@ configure(project(":lucene:analysis:common")) {
configure(project(":lucene:core")) {
setupIcuDependencies(project)
- tasks.register("generateUnicodeProps", {
+ tasks.register("generateCaseFolding", {
Review Comment:
Hi, i checked again the whole file `icu/build.gradle`: it sets up all three
tasks: One for `analysis-common` with above old name, and the new and renamed
one in `core`.
I am just wondering why the analysis-common's UnicodeProperties were not
updated. Maybe you did not run `regenerate` in the `analysis-common` module.
For completeness we should do this as analysis-icu was updated but we forgot to
regenerate all files.
Maybe we should have some consistency check that after an update of
dependency we get a warning/error if the files were not updated. Maybe this can
be done with the hash code JSON files. But that's something for a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
