rmuir commented on PR #16371: URL: https://github.com/apache/lucene/pull/16371#issuecomment-5107403320
> How does this differ from the `GenerateCaseFolding.groovy` script next to this one? Do they relate to each other? The naming is a bit strange..... > > The `GenerateCaseFolding.groovy` also has a wrong comment on the generated file (tells wrong command, maybe fix this while doing this PR). I would propose we consider renaming the .java and groovy files to be `CaseExpansion` for the stuff in automaton. The difference (this is just conceptual and of course its not doing A/a but only cornercases): * The automaton data "expands" an `A` to `[A, a]`. * The filter here is different and "folds" `A` and `a` to `a`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
