gnodet commented on code in PR #1080: URL: https://github.com/apache/maven/pull/1080#discussion_r1157757583
########## maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java: ########## @@ -158,7 +158,7 @@ public void testCalculateDegreeOfConcurrency() { int cpus = Runtime.getRuntime().availableProcessors(); assertEquals((int) (cpus * 2.2), cli.calculateDegreeOfConcurrency("2.2C")); assertEquals(1, cli.calculateDegreeOfConcurrency("0.0001C")); - assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("2.C")); + assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("2.xC")); Review Comment: When changing the related code, I found out that `2.C` was rejected early, although fully supported, so the test ended up failing after removing the early test which was using commons-lang `Validate`, as this part is completely duplicated by the exception thrown by the `Float.parseFloat` which also validates the syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org