gnodet commented on PR #1080: URL: https://github.com/apache/maven/pull/1080#issuecomment-1497298619
> Great to see these changes! I think the `is(Not)Empty` cases to move away from utils can also be reflected in an automated migration if you'd like me to roll that out across all of Maven. I think that was the most common use of utils. > > Other cases that came up in discussion elsewhere are not as clear in the general case, but can be automated in specific cases. For instance the utils `split` methods take a separator as a literal, rather than the regex it can be for `String.split`. We can explore what we can replace with JDK calls already, now, and I'll hold off on further Commons Lang changes while we do so. > > I'm traveling this week, so can't fully dive in, but hope to revisit the automations next week. Let me know if there's any over replacements that you'd like to distill from this one. Only looking to help & amplify changes such as this PR. Yes, the `split` calls can be translated directly when the separator is a one-char string. Other cases may need to be handled differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
