gnodet commented on code in PR #1080: URL: https://github.com/apache/maven/pull/1080#discussion_r1157760976
########## maven-core/src/main/java/org/apache/maven/internal/StringUtils.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.internal; Review Comment: I would challenge the _more attention_. The code has not changed in 16 years: https://github.com/apache/commons-lang/blob/LANG_2_0/src/java/org/apache/commons/lang/StringUtils.java#L221-L223. Again, I would agree if we were talking about any kind of substantial piece of code, but not one-liner functions... Anyway, I'll get rid of `isNotBlank` as I think the usage of this method (only 2 locations) is incoherent with all other checks in Maven. And I'll ask my editor to inline the other methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
