[GitHub] [maven] elharo commented on a diff in pull request #1080: [MNG-6825] Get rid of commons-lang

[via GitHub]

elharo commented on code in PR #1080:
URL: https://github.com/apache/maven/pull/1080#discussion_r1157809106


##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -158,7 +158,7 @@ public void testCalculateDegreeOfConcurrency() {
         int cpus = Runtime.getRuntime().availableProcessors();
         assertEquals((int) (cpus * 2.2), 
cli.calculateDegreeOfConcurrency("2.2C"));
         assertEquals(1, cli.calculateDegreeOfConcurrency("0.0001C"));
-        assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("2.C"));
+        assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("2.xC"));

Review Comment:
   OK, so it's an extra test. That's fine, but I suggest also keeping 
   
   ```
   assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("2.C"));
   ```



##########
maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java:
##########
@@ -89,10 +88,15 @@ public static String key(String groupId, String artifactId, 
String version) {
     }
 
     private static void notBlank(String str, String message) {
-        int c = str != null && str.length() > 0 ? str.charAt(0) : 0;
-        if ((c < '0' || c > '9') && (c < 'a' || c > 'z')) {
-            Validate.notBlank(str, message);
+        final int strLen = str != null ? str.length() : 0;

Review Comment:
   I was simply thinking
   
   ```
   if (str != null && !str.isEmpty())
   ```
   
   but this works too. Not a big deal. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org