gnodet-bot commented on code in PR #609:
URL: https://github.com/apache/maven-jar-plugin/pull/609#discussion_r4107220789
##########
pom.xml:
##########
@@ -221,14 +221,14 @@
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
- <excludes combine.children="append">
+ <inputExcludes>
Review Comment:
🔴 **Critical:** `combine.children="append"` must be preserved. Without it,
the 9 `<inputExcludes>` entries from `maven-parent:50` will be **replaced**
(not appended) by the 3 entries here, silently un-excluding files like
`.java-version`, `.repository/**`, `.asf.yaml`, etc.
All the other plugins that already migrated kept this attribute:
-
[maven-source-plugin](https://github.com/apache/maven-source-plugin/blob/master/pom.xml)
-
[maven-resources-plugin](https://github.com/apache/maven-resources-plugin/blob/master/pom.xml)
-
[maven-rar-plugin](https://github.com/apache/maven-rar-plugin/blob/master/pom.xml)
-
[maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin/blob/master/pom.xml)
-
[maven-deploy-plugin](https://github.com/apache/maven-deploy-plugin/blob/master/pom.xml)
```suggestion
<inputExcludes combine.children="append">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
