slawekjaranowski commented on PR #609: URL: https://github.com/apache/maven-jar-plugin/pull/609#issuecomment-5847625116
@gnodet > The combine.* attributes are inherited from parent to child POMs. Take care when adding those attributes to a parent POM as this might affect child or grand-child POMs. https://maven.apache.org/pom.html#advanced-configuration-inheritance-combine-children-and-combine so testing: ``` mvn help:effective-pom -Dverbose ``` give: ```xml <inputExcludes combine.children="append"> <exclude>.java-version</exclude> <!-- org.apache.maven:maven-parent:50, line 1285 --> <exclude>.repository/**</exclude> <!-- org.apache.maven:maven-parent:50, line 1287 --> <exclude>.maven/spy.log</exclude> <!-- org.apache.maven:maven-parent:50, line 1289 --> <exclude>dependency-reduced-pom.xml</exclude> <!-- org.apache.maven:maven-parent:50, line 1291 --> <exclude>.asf.yaml</exclude> <!-- org.apache.maven:maven-parent:50, line 1293 --> <exclude>.sdkmanrc</exclude> <!-- org.apache.maven:maven-parent:50, line 1295 --> <exclude>.tool-versions</exclude> <!-- org.apache.maven:maven-parent:50, line 1296 --> <exclude>.envrc</exclude> <!-- org.apache.maven:maven-parent:50, line 1297 --> <exclude>.mise.toml</exclude> <!-- org.apache.maven:maven-parent:50, line 1298 --> <exclude>src/it/mjar-71-01/src/main/my-custom-dir/some-manifest.mf</exclude> <!-- org.apache.maven.plugins:maven-jar-plugin:4.0.0-beta-2-SNAPSHOT, line 228 --> <exclude>src/it/mjar-71-02/src/main/resources/META-INF/MANIFEST.MF</exclude> <!-- org.apache.maven.plugins:maven-jar-plugin:4.0.0-beta-2-SNAPSHOT, line 229 --> <exclude>src/it/MJAR-557-detect-mjar/src/main/resources/META-INF/versions/9/test.txt</exclude> <!-- org.apache.maven.plugins:maven-jar-plugin:4.0.0-beta-2-SNAPSHOT, line 230 --> </inputExcludes> ``` the same result with and without `combine.children="append"` in child project also ``` mvn apache-rat:0.18:check -X ``` show the same in both cases: ``` [DEBUG] (s) inputExcludes = [.java-version, .repository/**, .maven/spy.log, dependency-reduced-pom.xml, .asf.yaml, .sdkmanrc, .tool-versions, .envrc, .mise.toml, src/it/mjar-71-01/src/main/my-custom-dir/some-manifest.mf, src/it/mjar-71-02/src/main/resources/META-INF/MANIFEST.MF, src/it/MJAR-557-detect-mjar/src/main/resources/META-INF/versions/9/test.txt] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
