fgerlits commented on code in PR #2254:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2254#discussion_r3970320695
##########
libminifi/include/core/controller/StandardControllerServiceNode.h:
##########
@@ -31,10 +31,9 @@ namespace org::apache::nifi::minifi::core::controller {
class StandardControllerServiceNode : public ControllerServiceNode {
public:
- explicit StandardControllerServiceNode(std::shared_ptr<ControllerService>
service, std::shared_ptr<ControllerServiceProvider> provider, std::string id,
- std::shared_ptr<Configure>
configuration)
+ explicit StandardControllerServiceNode(std::shared_ptr<ControllerService>
service, ControllerServiceProvider* provider, std::string id,
std::shared_ptr<Configure> configuration)
: ControllerServiceNode(std::move(service), std::move(id),
std::move(configuration)),
- provider(std::move(provider)),
+ provider(provider),
Review Comment:
Good point. I will revert this change, for now, as fixing it would be a
bigger change, and should go in a separate pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
