fgerlits commented on code in PR #2254:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2254#discussion_r3989888514
##########
cmake/BundledIodbc.cmake:
##########
@@ -33,7 +33,7 @@ ExternalProject_Add(
CMAKE_COMMAND ""
UPDATE_COMMAND ""
INSTALL_COMMAND make install
- CONFIGURE_COMMAND bash "-c" "./autogen.sh && ./configure
--prefix=${IODBC_BYPRODUCT_DIR} --with-pic CFLAGS='${CMAKE_C_FLAGS} -std=gnu17'"
+ CONFIGURE_COMMAND bash "-c" "./autogen.sh && ./configure
--prefix=${IODBC_BYPRODUCT_DIR} --with-pic CFLAGS='${PASSTHROUGH_CMAKE_C_FLAGS}
-std=gnu17'"
Review Comment:
This is unrelated to ASan, but it was clearly a bug, and it's a one-line
fix. I will remove it from this PR if requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
