fgerlits commented on code in PR #2254:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2254#discussion_r3990020235
##########
libminifi/test/unit/FileStreamTests.cpp:
##########
@@ -124,36 +124,6 @@ TEST_CASE("TestFileBadArgumentNoChange2", "[TestLoader]") {
REQUIRE(std::string(reinterpret_cast<char*>(data), verifybuffer.size()) ==
"tempFile");
}
-TEST_CASE("TestFileBadArgumentNoChange3", "[TestLoader]") {
- TestController testController;
- auto path = testController.createTempDirectory() / "tstFile.ext";
Review Comment:
I removed this test because now it is basically identical to the previous
one, and gcc 15.2 did not like the `string` constructor at line 154. This test
case used to test `stream.read(nullptr, 0)`, but we no longer support this
pointer syntax, only `std::span`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
