szaszm commented on code in PR #2254:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2254#discussion_r4017892607
##########
extension-framework/include/utils/net/ConnectionHandler.h:
##########
@@ -64,7 +66,7 @@ class ConnectionHandler final : public ConnectionHandlerBase {
[[nodiscard]] asio::awaitable<std::error_code>
setupUsableSocket(asio::io_context& io_context) override;
[[nodiscard]] bool hasUsableSocket() const { return socket_ &&
socket_->lowest_layer().is_open(); }
- asio::awaitable<std::error_code> establishNewConnection(const
asio::ip::tcp::resolver::results_type& endpoints, asio::io_context&
io_context_);
+ asio::awaitable<std::error_code> establishNewConnection(const
std::vector<asio::ip::tcp::endpoint>& endpoints, asio::io_context& io_context_);
Review Comment:
Why change this type? If we change it, why not go with something more
generic, like std::span?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
