fgerlits commented on code in PR #2254:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2254#discussion_r3989941707
##########
libminifi/test/libtest/integration/HTTPHandlers.h:
##########
@@ -40,9 +40,6 @@
namespace org::apache::nifi::minifi::test {
-static std::atomic<int> transaction_id;
-static std::atomic<int> transaction_id_output;
Review Comment:
This is also unrelated to ASan, but we used a local variable named
`transaction_id` somewhere where this header was included, and clang-tidy was
complaining about hiding a global variable. So I moved these two to the .cpp
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
