Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792218
--- Diff: libminifi/include/core/Processor.h ---
@@ -243,7 +244,7 @@ class Processor : public Connectable, public
ConfigurableComponent,
std::atomic<bool> _triggerWhenEmpty;
//! obtainSite2SiteProtocol for use
--- End diff --
In this case we may want to use a const reference to avoid the need to
increment and decrement the reference counter. This will avoid performance
issues, eventually. This isn't always required, but in places where the
callgraph may enter this function frequently, it's usually good practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
