Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861939
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -41,10 +42,12 @@ namespace core {
class YamlConfiguration : public FlowConfiguration {
public:
- YamlConfiguration(std::shared_ptr<core::Repository> repo,
- std::shared_ptr<core::Repository> flow_file_repo,
+ YamlConfiguration(const std::shared_ptr<core::Repository> &repo,
--- End diff --
might have to do the same here to avoid removing const ( which you can do
obviously )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
