Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114863373
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow controller constructor
*/
- FlowController(std::shared_ptr<core::Repository> provenance_repo,
- std::shared_ptr<core::Repository> flow_file_repo,
+ FlowController(const std::shared_ptr<core::Repository> &provenance_repo,
--- End diff --
we could move the original std shared ptr to subsume ownership, but I'm not
sure we want that. We want to say we're sharing ownership with this object and
thus this object ( FlowController ) helps in determining the lifetime of
shared_ptr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
