Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114860818
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow controller constructor
*/
- FlowController(std::shared_ptr<core::Repository> provenance_repo,
- std::shared_ptr<core::Repository> flow_file_repo,
+ FlowController(const std::shared_ptr<core::Repository> &provenance_repo,
--- End diff --
The reason these were pass by value was that we wanted to ensure that we
increment the ref counter for flow controller. Thus we won't deallocate memory
during its scope. It's a safety mechanism and more importantly indicates that
these need to survive FlowController
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
