Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861428
--- Diff: libminifi/include/core/ConfigurationFactory.h ---
@@ -30,25 +30,29 @@ namespace core {
template<typename T>
typename std::enable_if<!class_operations<T>::value, T*>::type instantiate(
- std::shared_ptr<core::Repository> repo,
- std::shared_ptr<core::Repository> flow_file_repo, const std::string
path) {
+ const std::shared_ptr<core::Repository> &repo,
+ const std::shared_ptr<core::Repository> &flow_file_repo, const
std::string path) {
throw std::runtime_error("Cannot instantiate class");
}
template<typename T>
typename std::enable_if<class_operations<T>::value, T*>::type instantiate(
- std::shared_ptr<core::Repository> repo,
- std::shared_ptr<core::Repository> flow_file_repo, const std::string
path) {
- return new T(repo, flow_file_repo, path);
+ const std::shared_ptr<core::Repository> &repo,
+ const std::shared_ptr<core::Repository> &flow_file_repo,
+ const std::shared_ptr<io::StreamFactory> &stream_factory,
+ const std::string path) {
+ return new T(repo, flow_file_repo, stream_factory, path);
}
/**
* Configuration factory is used to create a new FlowConfiguration
* object.
*/
std::unique_ptr<core::FlowConfiguration> createFlowConfiguration(
--- End diff --
Same as flow controller. The ones in instantiate, above, are fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
