tkhurana commented on code in PR #1967:
URL: https://github.com/apache/phoenix/pull/1967#discussion_r1746119626
##########
phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilder.java:
##########
@@ -102,7 +102,8 @@ public void
batchStarted(MiniBatchOperationInProgress<Mutation> miniBatchOp, Ind
@Override
public boolean isAtomicOp(Mutation m) {
- return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null;
+ return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null ||
Review Comment:
I am slightly confused here. I was under the impression that RETURN_RESULT
is only supported for atomic upserts. But this implies non atomic upserts could
also get return result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
