virajjasani commented on code in PR #1967:
URL: https://github.com/apache/phoenix/pull/1967#discussion_r1746175713
##########
phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilder.java:
##########
@@ -102,7 +102,8 @@ public void
batchStarted(MiniBatchOperationInProgress<Mutation> miniBatchOp, Ind
@Override
public boolean isAtomicOp(Mutation m) {
- return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null;
+ return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null ||
Review Comment:
I was thinking about that and then realized that even if we do it, we sort
of are making returnResult as atomic usecase internally (if not for UPSERT, at
least for DELETE), that's why i kept it here. WDYT? Shall we still keep it this
way or make callers do extra call for where `if (isAtomicOp() ||
hasReturnResult)` is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
