virajjasani commented on code in PR #1967:
URL: https://github.com/apache/phoenix/pull/1967#discussion_r1746179313
##########
phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilder.java:
##########
@@ -102,7 +102,8 @@ public void
batchStarted(MiniBatchOperationInProgress<Mutation> miniBatchOp, Ind
@Override
public boolean isAtomicOp(Mutation m) {
- return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null;
+ return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null ||
Review Comment:
> Another reason is let say tomorrow I want to do something just for ON
DUPLICATE KEY but not for return result.
That sounds valid, let me make them different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
