virajjasani commented on code in PR #1967:
URL: https://github.com/apache/phoenix/pull/1967#discussion_r1746136426
##########
phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilder.java:
##########
@@ -102,7 +102,8 @@ public void
batchStarted(MiniBatchOperationInProgress<Mutation> miniBatchOp, Ind
@Override
public boolean isAtomicOp(Mutation m) {
- return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null;
+ return m.getAttribute(PhoenixIndexBuilderHelper.ATOMIC_OP_ATTRIB) !=
null ||
Review Comment:
Yes that's correct but this is done to do some preparation to support DELETE
in advance. Because with Delete, we don't have ON DUPLICATE KEY clause, nor do
we want to support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
