tkhurana commented on code in PR #2357:
URL: https://github.com/apache/phoenix/pull/2357#discussion_r2743238861
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -2529,7 +2529,11 @@ private PTable createTableInternal(CreateTableStatement
statement, byte[][] spli
} else {
ttlFromHierarchy = checkAndGetTTLFromHierarchy(parent, tableName);
if (!ttlFromHierarchy.equals(TTL_EXPRESSION_NOT_DEFINED)) {
- ttlFromHierarchy.validateTTLOnCreate(connection, statement, parent,
tableProps);
+ if (parent.hasConditionalTTL() && !parent.isStrictTTL()) {
+ ttlFromHierarchy = TTL_EXPRESSION_NOT_DEFINED;
Review Comment:
With this change even for covered index any relaxed conditional ttl will
become undefined. I don't think that is intended right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
