tkhurana commented on code in PR #2357:
URL: https://github.com/apache/phoenix/pull/2357#discussion_r2747372543
##########
phoenix-core/src/test/java/org/apache/phoenix/schema/ConditionalTTLExpressionTest.java:
##########
@@ -602,6 +620,34 @@ public void
testSettingCondTTLOnTableWithIndexWithMissingExprCols() throws Excep
} catch (SQLException e) {
assertTrue(e.getCause() instanceof ColumnNotFoundException);
}
+ // relaxed ttl
+ ddl = String.format("alter table %s set TTL = '%s', IS_STRICT_TTL =
false", tableName,
+ retainSingleQuotes(ttl));
+ try {
+ conn.createStatement().execute(ddl);
+ fail("Should have thrown ColumnNotFoundException");
+ } catch (SQLException e) {
+ assertTrue(e.getCause() instanceof ColumnNotFoundException);
+ }
+ }
+ }
+
+ @Test
Review Comment:
Can you also add a test case where the table has uncovered index and a
literal TTL. Now you alter the ttl to conditional with IS_STRICT_TTL set to
false. Then verify that the table has conditional ttl and the uncovered index
has ttl undefined. I am suspecting that while you skipped checking for
uncovered indexes during the ttl validation on alter, I am not seeing that you
are actually updating the ttl on uncovered index to undefined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
