palashc commented on code in PR #2357:
URL: https://github.com/apache/phoenix/pull/2357#discussion_r2766562943
##########
phoenix-core/src/test/java/org/apache/phoenix/schema/ConditionalTTLExpressionTest.java:
##########
@@ -602,6 +620,34 @@ public void
testSettingCondTTLOnTableWithIndexWithMissingExprCols() throws Excep
} catch (SQLException e) {
assertTrue(e.getCause() instanceof ColumnNotFoundException);
}
+ // relaxed ttl
+ ddl = String.format("alter table %s set TTL = '%s', IS_STRICT_TTL =
false", tableName,
+ retainSingleQuotes(ttl));
+ try {
+ conn.createStatement().execute(ddl);
+ fail("Should have thrown ColumnNotFoundException");
+ } catch (SQLException e) {
+ assertTrue(e.getCause() instanceof ColumnNotFoundException);
+ }
+ }
+ }
+
+ @Test
Review Comment:
@tkhurana I made this change, let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
