tkhurana commented on code in PR #2357:
URL: https://github.com/apache/phoenix/pull/2357#discussion_r2743297669
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -6413,7 +6417,11 @@ private boolean evaluateStmtProperties(MetaProperties
metaProperties,
}
if (metaProperties.getTTL() != table.getTTLExpression()) {
TTLExpression newTTL = metaProperties.getTTL();
- newTTL.validateTTLOnAlter(connection, table);
+ boolean isStrictTTL =
+ metaProperties.isStrictTTL() != null ? metaProperties.isStrictTTL :
table.isStrictTTL();
+ if (!(newTTL instanceof ConditionalTTLExpression) || isStrictTTL) {
+ newTTL.validateTTLOnAlter(connection, table);
Review Comment:
It would be better if you pass the isStrictTTL to the validateTTLOnAlter
function and then in the specific implementation of conditional ttl expression
skip the checks for uncovered index if the ttl is not strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
