[ 
https://issues.apache.org/jira/browse/SOLR-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464756#comment-17464756
 ] 

Chris M. Hostetter commented on SOLR-15321:
-------------------------------------------

{quote}And we need to generate and maintain the TAGS file in some way. We could 
copy the 7.7.3 and 8.11.1 lines from docker-solr and have them as static 
include.
{quote}
I'm pretty sure there is no "rule" that we need a TAGS file, IIRC that's 
basically just a "temp" file produced by some of the existing docker-solr 
scripts (inherited/copied from other docker repos) to help iterate over when 
running tests, and to use as input to produce the 
{{docker-library/official-images/library/solr}} file.

A lot of the existing {{docker-solr/docker-solr}} "release" scripts won't 
really make sense for {{apache/docker-solr}} (because we won't be "scraping" 
the release mirrors for lists of 9.x releases) but even if it makes sense to 
keep a {{apache/docker-solr/TAGS}} file around (but generated by some new 
script that knows about the {{Dockerfile.official}} files we explicitly add to 
subdirs & commit on each release) i think it can/should just be for the 9.x 
releases – the pre 9.x releases that we want in 
{{docker-library/official-images/library/solr}} can be statically 
generated/included (just like the header) with {{GitRepo}} lines for those 
releases pointing to the old {{docker-solr/docker-solr}} repo.

Or to try and boil it down into what i think are the simplest possible steps:
 * make {{apache/docker-solr/generate-stackbrew-library.sh}} slurp in some 
{{pre-9.manifest.txt}} file
 * update {{docker-solr/docker-solr/generate-stackbrew-library.sh}} to output 
an explicit {{GitRepo}} for every release
 * update the {{docker-solr/docker-solr}} release instructions to indicate that 
if/when patching a 7.x or 8.x release:
 ** instead of submitting a PR to 
{{docker-library/official-images/library/solr}} after running 
{{generate-stackbrew-library.sh}} ...
 ** ...submit a pr to {{apache/docker-solr/pre-9.manifest.txt}} to modifify

> Flesh out process for managing/storing "official" Dockerfiles used by 
> docker-library
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-15321
>                 URL: https://issues.apache.org/jira/browse/SOLR-15321
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Assignee: Houston Putman
>            Priority: Blocker
>             Fix For: main (9.0)
>
>
> Assuming we (the Apache Solr TLP) do want to be the maintainer of "official" 
> {{_/solr}} docker images moving forward, we need to flesh out how/where 
> exactly we plan on storing/managing/maintaining the Dockerfiles that should 
> be pointed to by the docker-library manifest file for solr...
> [https://github.com/docker-library/official-images/blob/master/library/solr]
> ie:
>  * what replaces [https://github.com/docker-solr/docker-solr.git]
>  * what process do we use to update/manage this?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to