stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303744008
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
"solr.distributedClusterStateUpdates",
Boolean.toString(useDistributedClusterStateUpdate));
+ // eager init to prevent OTEL init races caused by test setup
+ if (!disableTraceIdGeneration &&
TracerConfigurator.TRACE_ID_GEN_ENABLED) {
+ SimplePropagator.load();
+ }
+
Review Comment:
I removed something that was not needed anymore
https://github.com/apache/solr/pull/1841/files#diff-7cb8f3a46dbdb99ccfdcc1d07c4457167188e7366534a7e7e4a0b5aff93c1cc4L327
this is here because it's the place that boots up a multi node cluster and
causing multiple OTEL inits to happen in the same jvm. I believe this is the
good place for it because this is where the cluster gets setup. it is not
suited for the STCJ4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
