dsmiley commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1689973250
> I would propose to go for a simpler solution though, first this was already solved for us by the many #wrap methods on the context and second trace context is always on, might as well make it a proper wrap rather than playing with that provider. At the cost of yet another dependency, and to SolrJ at that? I'm sensitive to dependency sprawl, and in SolrJ in particular. Since Solr already has a mechanism for the server side to cause ExecutorUtil to have an additional general wrapping functionality via ThreadLocalProvider, I think we should use it. That said, I've found it to be a more complicated a mechanism than it could be, but it hasn't quite bothered me enough to simplify it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
