stillalex commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1690076906
> At the cost of yet another dependency, and to SolrJ at that? I'm sensitive to dependency sprawl, and in SolrJ in particular. this argument I agree with. it's awkward to bring in another dependency, but there is still a major todo here, to enable auto-trace generation, and for this there is a high likelihood that we'll need to import some otel library, not sure which one yet. > Since Solr already has a mechanism for the server side to cause ExecutorUtil to have an additional general wrapping functionality via ThreadLocalProvider, I think we should use it. That said, I've found it to be a more complicated a mechanism than it could be, but it hasn't quite bothered me enough to simplify it. I'm not sold on this part. the existing mechanism copies is overly complex for solving an already solved problem. perhaps at the time is was good to build it this way, but I think it is well worth it to reconsider. this being said, if the auto-generation has a zero-dependency solution, I will be happy to reconsider the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
