stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303750750


##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
           "solr.distributedClusterStateUpdates",
           Boolean.toString(useDistributedClusterStateUpdate));
 
+      // eager init to prevent OTEL init races caused by test setup
+      if (!disableTraceIdGeneration && 
TracerConfigurator.TRACE_ID_GEN_ENABLED) {
+        SimplePropagator.load();
+      }
+

Review Comment:
   just checking I read your message correctly. are you starting multiple solr 
instances as a part of a test and not using the MiniSolrCloudCluster? in this 
case, sure I can consider moving so it covers all solr flavors. if it's not a 
multi solr setup, the race does not happen and there is no issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to