stillalex commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303771997
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
"solr.distributedClusterStateUpdates",
Boolean.toString(useDistributedClusterStateUpdate));
+ // eager init to prevent OTEL init races caused by test setup
+ if (!disableTraceIdGeneration &&
TracerConfigurator.TRACE_ID_GEN_ENABLED) {
+ SimplePropagator.load();
+ }
+
Review Comment:
> Is it because we need only concern ourselves with tests touching tracing?
no, with the "always on trace id" all tests are using tracing.
the core issue is with OTEL init method. it will not allow setting the
global object more than once and will fail loudly if you try, so we'd see a
test failure. I am assuming the other tests do not have the same level of
concurrency on multiple solr instances coming online, so maybe the race is less
likely to occur as in the case of the MiniSolrCloudCluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
