dsmiley commented on code in PR #3423:
URL: https://github.com/apache/solr/pull/3423#discussion_r2224270210
##########
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##########
@@ -681,8 +680,8 @@ private UpdateCommand
fetchFullUpdateFromLeader(AddUpdateCommand inplaceAdd, lon
params.set(DISTRIB, false);
params.set("getInputDocument", id);
params.set("onlyIfActive", true);
- SolrRequest<SimpleSolrResponse> ur =
- new GenericSolrRequest(METHOD.GET, "/get",
params).setRequiresCollection(true);
+ var ur =
+ new GenericCollectionRequest(METHOD.GET, "/get",
SolrRequest.SolrRequestType.ADMIN, params);
Review Comment:
tldr; this is fine.
Right; wouldn't get rate limited because is internal ([here's the
logic](https://github.com/apache/solr/blob/7279b808628a9286def7aea8b3b00f626df23dec/solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java#L102)).
And what I said about LBSolrClient is somewhat/conditionally true
([logic](https://github.com/apache/solr/blob/e08d7f0f0e66cdde389eb843db341f0eb5d833bb/solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java#L457));
this admin request would still be retry-able because it's a core admin request
instead of node level. Gosh I don't like the logic there; it ought to be super
simple/general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
