dsmiley commented on PR #3423: URL: https://github.com/apache/solr/pull/3423#issuecomment-3130084660
I hear your concern. Personally it doesn't seem like things are out of hand because the settings we're talking about are binary (requiresCollection, V2). I *really* think V2 most of all needs to be separate classes (and they are). But requiresCollection could be a mandatory constructor parameter to GenericSolrRequest. Maybe even an enum to make the call-site clear as to what is being toggled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
