gerlowskija commented on PR #3423: URL: https://github.com/apache/solr/pull/3423#issuecomment-3174880911
> Personally it doesn't seem like things are out of hand because the settings we're talking about are binary (requiresCollection, V2). I really think V2 most of all needs to be separate classes (and they are). But requiresCollection could be a mandatory constructor parameter to GenericSolrRequest. So, if I understand that right, we would keep the same two classes we have currently: `GenericSolrRequest` and `GenericV2SolrRequest`. The collection-or-not axis would be handled by removing the `setRequiresCollection` setter, and replacing it with a ctor parameter which forces callers to at least consider the question? Assuming I've got that right, that sounds reasonable to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
