gerlowskija commented on PR #3423: URL: https://github.com/apache/solr/pull/3423#issuecomment-3206406923
> So I don't know how to make both of us happy now. I kindof thought we'd found a compromise approach in what you suggested [here](https://github.com/apache/solr/pull/3423#issuecomment-3130084660): "I really think V2 most of all needs to be separate classes (and they are). But requiresCollection could be a mandatory constructor parameter to GenericSolrRequest. " I'm 👍 to that, and since you suggested it I assumed you were as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
