dsmiley commented on PR #3423: URL: https://github.com/apache/solr/pull/3423#issuecomment-3194426331
> 2. You can create a ctor-param for each dimension maybe. This starts to make the ctor's a little unwieldy to call Right. As I look at GenericSolrCollection, I've completely lost motivation to follow through with this. So I don't know how to make both of us happy now. I'll repeat that I think the collection or node level is a significant enough matter that it's worthy of being in the class hierarchy. I wouldn't say that for the other booleans other than V2. I guess I'll back out the class I added and live with GenericSolrCollection. I don't like that it's easy to overlook the request type. Maybe the constructors that don't take that should be deprecated; shrug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
